wuchong commented on code in PR #2074:
URL: https://github.com/apache/fluss/pull/2074#discussion_r2579943115
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/MetadataManager.java:
##########
@@ -562,10 +562,14 @@ public TableInfo getTable(TablePath tablePath) throws
TableNotExistException {
}
TableRegistration tableReg = optionalTable.get();
SchemaInfo schemaInfo = getLatestSchema(tablePath);
- Map<String, String> tableLakeOptions =
-
lakeCatalogDynamicLoader.getLakeCatalogContainer().getDefaultTableLakeOptions();
- removeSensitiveTableOptions(tableLakeOptions);
- return tableReg.toTableInfo(tablePath, schemaInfo, tableLakeOptions);
+ LakeCatalogDynamicLoader.LakeCatalogContainer lakeCatalogContainer =
+ lakeCatalogDynamicLoader.getLakeCatalogContainer();
+
removeSensitiveTableOptions(lakeCatalogContainer.getDefaultTableLakeOptions());
+ return tableReg.toTableInfo(
+ tablePath,
+ schemaInfo,
+ lakeCatalogContainer.getDefaultTableLakeOptions(),
+ lakeCatalogContainer.getDataLakeFormat());
Review Comment:
We can't simply put it in virtual properties, because it affects key
encoding and should be a physical properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
