xx789633 commented on code in PR #1887:
URL: https://github.com/apache/fluss/pull/1887#discussion_r2585419872
##########
fluss-common/src/main/java/org/apache/fluss/metadata/Schema.java:
##########
@@ -62,8 +63,11 @@ public final class Schema implements Serializable {
private final @Nullable PrimaryKey primaryKey;
private final RowType rowType;
- private Schema(List<Column> columns, @Nullable PrimaryKey primaryKey) {
- this.columns = normalizeColumns(columns, primaryKey);
+ private Schema(
+ List<Column> columns,
+ @Nullable PrimaryKey primaryKey,
+ @Nullable String autoIncrementColumn) {
+ this.columns = normalizeColumns(columns, primaryKey,
autoIncrementColumn);
Review Comment:
Thanks for the comment. It's true that adding extra fields in `Column`
complicates its API. Comments addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
