wuchong commented on code in PR #2093:
URL: https://github.com/apache/fluss/pull/2093#discussion_r2587222208
##########
fluss-client/src/main/java/org/apache/fluss/client/lookup/LookupClient.java:
##########
@@ -78,14 +79,17 @@ private ExecutorService createThreadPool() {
return Executors.newFixedThreadPool(1, new
ExecutorThreadFactory(LOOKUP_THREAD_PREFIX));
}
- public CompletableFuture<byte[]> lookup(TableBucket tableBucket, byte[]
keyBytes) {
- LookupQuery lookup = new LookupQuery(tableBucket, keyBytes);
+ public CompletableFuture<byte[]> lookup(
+ TableInfo tableInfo, TableBucket tableBucket, byte[] keyBytes) {
Review Comment:
Use `TablePath` is enough?
##########
fluss-client/src/main/java/org/apache/fluss/client/lookup/LookupClient.java:
##########
@@ -78,14 +79,17 @@ private ExecutorService createThreadPool() {
return Executors.newFixedThreadPool(1, new
ExecutorThreadFactory(LOOKUP_THREAD_PREFIX));
}
- public CompletableFuture<byte[]> lookup(TableBucket tableBucket, byte[]
keyBytes) {
- LookupQuery lookup = new LookupQuery(tableBucket, keyBytes);
+ public CompletableFuture<byte[]> lookup(
+ TableInfo tableInfo, TableBucket tableBucket, byte[] keyBytes) {
+ LookupQuery lookup = new LookupQuery(tableInfo.getTablePath(),
tableBucket, keyBytes);
lookupQueue.appendLookup(lookup);
return lookup.future();
}
- public CompletableFuture<List<byte[]>> prefixLookup(TableBucket
tableBucket, byte[] keyBytes) {
- PrefixLookupQuery prefixLookup = new PrefixLookupQuery(tableBucket,
keyBytes);
+ public CompletableFuture<List<byte[]>> prefixLookup(
+ TableInfo tableInfo, TableBucket tableBucket, byte[] keyBytes) {
Review Comment:
Use `TablePath` is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
