rionmonster commented on PR #2115: URL: https://github.com/apache/fluss/pull/2115#issuecomment-3627078617
@wuchong I was looking into this issue and based on the previously touched files, I figured that you'd be the person to ask. I was running into local issues when working on a separate issue related to Maven and noticed the version we are targeting is no longer supported. I attempted to upgrade it (along with its references), but noticed that this caused the Maven Enforcer plugin to fail the CI builds for Java 11 since it defaults to Maven 3.8.6, which doesn't fall into the updated enforcement range introduced in this pull request (from `<version>[3.8.6,)</version>` to `<version>[3.9.11,)</version>`). I'm not certain what the best course of action here would be, so I wanted your feedback. My initial approaches would be: - **Leverage Maven Wrapper for CI** - Currently the CI builds call Maven directly (e.g. `mvn ...`) however I'm curious if we could update the CI template to use the wrapper as well (uncertain how feasible this is) for consistency across the different builds. - **Specifying Build Version** - Update the existing Java 11 CI builds to explicitly set the Maven version to the new target of 3.9.11. - **Relaxing Enforcement** - Just revert the target enforcement version to the previous 3.8.6 to support these older versions. IMO, not ideal since I think we want to get away from those deprecated versions everywhere, but it would support the CI use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
