xx789633 commented on code in PR #2161:
URL: https://github.com/apache/fluss/pull/2161#discussion_r2614531113


##########
fluss-common/src/test/java/org/apache/fluss/metadata/TableDescriptorTest.java:
##########
@@ -316,4 +316,7 @@ void testPartitionedTable() {
                 .hasMessage(
                         "Bucket key [f0, f3] shouldn't include any column in 
partition keys [f0].");
     }
+

Review Comment:
   remove this



##########
fluss-common/src/main/java/org/apache/fluss/metadata/Schema.java:
##########
@@ -115,6 +115,15 @@ public int[] getPrimaryKeyIndexes() {
                 .orElseGet(() -> new int[0]);
     }
 
+    /** Returns the auto-increment column index, if any, otherwise returns -1. 
*/

Review Comment:
   This PR does not need to modify the schema part. Please use the latest 
schema definition code containing the auto increment column on main branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to