caozhen1937 commented on code in PR #2126:
URL: https://github.com/apache/fluss/pull/2126#discussion_r2616024248
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/MetadataManager.java:
##########
@@ -279,7 +284,12 @@ public long createTable(
boolean ignoreIfExists)
throws TableAlreadyExistException, DatabaseNotExistException {
// validate table properties before creating table
- validateTableDescriptor(tableToCreate, maxBucketNum);
+ int dbLevelMaxBucket =
+ DatabaseLimitResolver.resolveMaxBucketForDb(
+ maxBucketNum,
+ dynamicConfigManager.describeConfigs(),
+ tablePath.getDatabaseName());
+ validateTableDescriptor(tableToCreate, maxBucketNum, dbLevelMaxBucket);
Review Comment:
@swuferhong `maxBucketNum` is still used to represent the maximum limit of
the cluster. I will use two variables to distinguish them: `maxBucketNumOfDb`
and `maxBucketNumOfCluster`. How do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
