zhaohaidao commented on code in PR #93:
URL: https://github.com/apache/fluss-rust/pull/93#discussion_r2617143255
##########
crates/fluss/src/client/table/remote_log.rs:
##########
@@ -115,11 +116,19 @@ impl RemoteLogDownloadFuture {
/// Downloader for remote log segment files
pub struct RemoteLogDownloader {
local_log_dir: TempDir,
+ s3_props: RwLock<HashMap<String, String>>,
Review Comment:
My idea here is this: the current implementation follows the principle of
simplicity, avoiding over-encapsulation. Seeing the 's3' prefix should clearly
indicate that this is the configuration used by s3, and other remote storages
should not use it.
Do you have any suggestions? If you want different RemoteDownloaders to be
implemented for different remote storages, I can also modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
