Copilot commented on code in PR #96:
URL: https://github.com/apache/fluss-rust/pull/96#discussion_r2617869136
##########
crates/fluss/src/io/file_io.rs:
##########
@@ -97,12 +97,10 @@ impl FileIOBuilder {
}
}
-#[async_trait::async_trait]
pub trait FileRead: Send + Unpin + 'static {
- async fn read(&self, range: Range<u64>) -> Result<Bytes>;
+ fn read(&self, range: Range<u64>) -> impl Future<Output = Result<Bytes>> +
Send;
Review Comment:
Missing import for Future trait. The trait method signature uses `impl
Future` as a return type but `std::future::Future` is not imported. Add `use
std::future::Future;` to the imports at the top of the file.
##########
crates/fluss/src/rpc/server_connection.rs:
##########
@@ -189,8 +190,8 @@ where
match map.remove(&header.request_id) {
Some(active_request) => active_request,
_ => {
- warn!(
- request_id = header.request_id,
+ log::warn!(
+ request_id:% = header.request_id;
"Got response for unknown request",
Review Comment:
Invalid syntax for log macro. The log crate doesn't support the `key:% =
value;` syntax from tracing. Use standard formatting instead, such as:
`log::warn!("Got response for unknown request, request_id: {}",
header.request_id);` or with the kv_std feature: `log::warn!(request_id =
header.request_id; "Got response for unknown request");` (note the semicolon
placement and lack of `:% =`).
```suggestion
"Got response for unknown
request, request_id: {}",
header.request_id
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
