loserwang1024 commented on code in PR #2152:
URL: https://github.com/apache/fluss/pull/2152#discussion_r2621527395
##########
fluss-flink/fluss-flink-2.1/src/main/java/org/apache/fluss/flink/catalog/Flink21Catalog.java:
##########
@@ -44,11 +46,29 @@ public Flink21Catalog(
super(name, defaultDatabase, bootstrapServers, classLoader,
securityConfigs);
}
+ @VisibleForTesting
+ public Flink21Catalog(
+ String name,
+ String defaultDatabase,
+ String bootstrapServers,
+ ClassLoader classLoader,
+ Map<String, String> securityConfigs,
+ LakeFlinkCatalog lakeFlinkCatalog) {
+ super(
+ name,
+ defaultDatabase,
+ bootstrapServers,
+ classLoader,
+ securityConfigs,
+ lakeFlinkCatalog);
+ }
+
@Override
public CatalogBaseTable getTable(ObjectPath objectPath)
throws TableNotExistException, CatalogException {
CatalogBaseTable catalogBaseTable = super.getTable(objectPath);
- if (!(catalogBaseTable instanceof CatalogTable)) {
+ if (!(catalogBaseTable instanceof CatalogTable)
Review Comment:
Yes, it's why I add FlinkCatalog21Test which extends FlinkCatalogTest. In
FlinkCatalogTest, I add a content to test get $lake:
<img width="746" height="161" alt="image"
src="https://github.com/user-attachments/assets/7a4b4758-f707-4a92-9e49-5544459be232";
/>
without this fix, this test will success in FlinkCatalogTest but fail in
FlinkCatalog21Test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
