buvb commented on code in PR #2189:
URL: https://github.com/apache/fluss/pull/2189#discussion_r2625763558
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/SchemaUpdate.java:
##########
@@ -83,9 +84,14 @@ public SchemaUpdate applySchemaChange(TableChange
columnChange) {
}
private SchemaUpdate addColumn(TableChange.AddColumn addColumn) {
- if (existedColumns.containsKey(addColumn.getName())) {
- throw new IllegalArgumentException(
- "Column " + addColumn.getName() + " already exists.");
+ Schema.Column existingColumn = existedColumns.get(addColumn.getName());
Review Comment:
Will add a comment to explain the idempotent handling in [SchemaUpdate]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
