wuchong commented on code in PR #2063:
URL: https://github.com/apache/fluss/pull/2063#discussion_r2631849110
##########
fluss-flink/fluss-flink-1.20/pom.xml:
##########
@@ -71,6 +71,13 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-streaming-java</artifactId>
+ <version>${flink.minor.version}</version>
+ <scope>provided</scope>
Review Comment:
Why do we need the dependency? `MultipleParameterTool` is not in
`flink-streaming-java`, right?
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/adapter/MultipleParameterToolAdapter.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.fluss.flink.adapter;
+
+import org.apache.flink.api.java.utils.MultipleParameterTool;
+
+import java.util.Map;
+
+/** A adapter for flink 1.x {@link MultipleParameterTool} . */
Review Comment:
```suggestion
/**
* An adapter for Flink {@link MultipleParameterTool} class. The {@link
MultipleParameterTool} is
* moved to a new package since Flink 2.x, so this adapter helps to bridge
compatibility for
* different Flink versions.
*
* <p>TODO: remove this class when no longer support all the Flink 1.x
series.
*/
```
Add more comment to explain why we need this adapter. Please update all the
`MultipleParameterToolAdapter`s.
##########
fluss-flink/fluss-flink-1.18/src/main/java/org/apache/fluss/flink/adapter/MultipleParameterToolAdapter.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.fluss.flink.adapter;
+
+import org.apache.flink.api.java.utils.MultipleParameterTool;
+
+import java.util.Map;
+
+/** A adapter for flink 1.x {@link MultipleParameterTool} . */
+public class MultipleParameterToolAdapter {
Review Comment:
We don't need to add the adapter for the 1.18, 1.19, 1.20 modules, because
they are the same code with the `fluss-flink-common`, and no need to override
the class. We only need to add the adapter for 2.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
