leekeiabstraction commented on code in PR #97:
URL: https://github.com/apache/fluss-rust/pull/97#discussion_r2636354586


##########
crates/fluss/src/record/arrow.rs:
##########
@@ -523,7 +523,8 @@ impl<'a> LogRecordBatch<'a> {
 /// - `body_buffer`: The buffer containing the record batch body data.
 /// - `version`: The Arrow IPC metadata version.
 ///
-/// Returns `None` if the data is malformed or too short.
+/// # Panics
+/// Panics if the data is malformed e.g. too short or bad continuation marker.

Review Comment:
   Great suggestion! Addressed your comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to