vamossagar12 commented on PR #2167: URL: https://github.com/apache/fluss/pull/2167#issuecomment-3678357668
> I also consider whether we need to move Flink21CatalogFactory to fluss-flink-common . Then flink 2.1 and 2.2 can share it. No need too much same code. > > FlinkCatalogFactory > > * flink 1.18 > * flink 1.19 > * fink 1.20 > * flink 2.0 > > FlinkCatalogGreeterThan21Factory > > * fink 2.1 > * fink 2.2 > > flink below 2.0 won't use FlinkCatalogGreeterThan21Factory code. Thus no problem will occurs. Thanks, I was thinking to do it in a subsequent PR. This PR also doesn't create an adapter layer for Flink 2.2,. we can adopt a similar approach for 2.1 in the common code. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
