platinumhamburg commented on code in PR #2178:
URL: https://github.com/apache/fluss/pull/2178#discussion_r2642918423
##########
fluss-server/src/main/java/org/apache/fluss/server/kv/rocksdb/RocksDBResourceContainer.java:
##########
@@ -73,29 +74,41 @@ public class RocksDBResourceContainer implements
AutoCloseable {
private final boolean enableStatistics;
+ /** The shared rate limiter for all RocksDB instances. */
+ private final RateLimiter sharedRateLimiter;
+
/** The handles to be closed when the container is closed. */
private final ArrayList<AutoCloseable> handlesToClose;
@VisibleForTesting
RocksDBResourceContainer() {
- this(new Configuration(), null, false);
+ this(new Configuration(), null, false, null);
}
public RocksDBResourceContainer(ReadableConfig configuration, @Nullable
File instanceBasePath) {
- this(configuration, instanceBasePath, false);
+ this(configuration, instanceBasePath, false, null);
}
public RocksDBResourceContainer(
ReadableConfig configuration,
@Nullable File instanceBasePath,
boolean enableStatistics) {
+ this(configuration, instanceBasePath, enableStatistics, null);
Review Comment:
Since RocksDBResourceContainer is instance-scoped, a non-shared RateLimiter
is meaningless and cannot effectively control service-level traffic. I will
remove the overloaded constructor that doesn’t accept a RateLimiter, and
instead create a shared RateLimiter at the KvManager layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
