rionmonster commented on code in PR #2195:
URL: https://github.com/apache/fluss/pull/2195#discussion_r2643453839
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/metrics/FlinkHistogram.java:
##########
@@ -41,10 +41,7 @@ public long getCount() {
@Override
public HistogramStatistics getStatistics() {
-
- wrapped.getStatistics();
-
- return null;
+ return new FlinkHistogramStatistics(wrapped.getStatistics());
Review Comment:
@wuchong
I wasn't sure on this one. While it totally makes sense to add the
additional null check, do you have a preference in terms of the null-handling
behavior? Would we prefer to throw an exception? Or should be consider logging
something and returning some default object?
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
