vamossagar12 commented on code in PR #2167:
URL: https://github.com/apache/fluss/pull/2167#discussion_r2645049561
##########
fluss-flink/fluss-flink-2.2/src/test/java/org/apache/fluss/flink/catalog/FlinkCatalog22Test.java:
##########
@@ -59,4 +46,30 @@ protected ResolvedSchema createSchema() {
DefaultIndex.newIndex(
"INDEX_first_third", Arrays.asList("first",
"third"))));
}
+
+ protected CatalogMaterializedTable newCatalogMaterializedTable(
+ ResolvedSchema resolvedSchema,
+ CatalogMaterializedTable.RefreshMode refreshMode,
+ Map<String, String> options) {
+ CatalogMaterializedTable origin =
+ CatalogMaterializedTable.newBuilder()
+
.schema(Schema.newBuilder().fromResolvedSchema(resolvedSchema).build())
+ .comment("test comment")
+ .options(options)
+ .partitionKeys(Collections.emptyList())
+ .definitionQuery("select first, second, third from t")
+ .freshness(IntervalFreshness.of("5",
IntervalFreshness.TimeUnit.SECOND))
+ .logicalRefreshMode(
+ refreshMode ==
CatalogMaterializedTable.RefreshMode.CONTINUOUS
+ ?
CatalogMaterializedTable.LogicalRefreshMode.CONTINUOUS
+ :
CatalogMaterializedTable.LogicalRefreshMode.FULL)
+ .refreshMode(refreshMode)
+
.refreshStatus(CatalogMaterializedTable.RefreshStatus.INITIALIZING)
+ .build();
+ return new ResolvedCatalogMaterializedTable(
+ origin,
+ resolvedSchema,
+ refreshMode,
+ IntervalFreshness.of("5", IntervalFreshness.TimeUnit.SECOND));
Review Comment:
I removed the override method `newCatalogMaterializedTable` from
`Flink22CatalogTest` as it's implementation was the same as the one in the base
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
