wuchong commented on code in PR #2154:
URL: https://github.com/apache/fluss/pull/2154#discussion_r2648252725
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/source/reader/FlinkSourceSplitReader.java:
##########
@@ -188,15 +188,10 @@ public void
handleSplitsChanges(SplitsChange<SourceSplitBase> splitsChanges) {
}
for (SourceSplitBase sourceSplitBase : splitsChanges.splits()) {
LOG.info("add split {}", sourceSplitBase.splitId());
- // init table id
- if (tableId == null) {
- tableId = sourceSplitBase.getTableBucket().getTableId();
- } else {
- checkArgument(
-
tableId.equals(sourceSplitBase.getTableBucket().getTableId()),
- "table id not equal across splits {}",
- splitsChanges.splits());
- }
+ checkArgument(
+
tableId.equals(sourceSplitBase.getTableBucket().getTableId()),
+ "table id not equal across splits {}",
Review Comment:
Make the exception message more clear to users, what table path, what is the
different table ids, why this error happens, how to resolve this error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
