XuQianJin-Stars commented on code in PR #2260:
URL: https://github.com/apache/fluss/pull/2260#discussion_r2649573468
##########
fluss-lake/fluss-lake-paimon/src/test/java/org/apache/fluss/lake/paimon/tiering/PaimonTieringITCase.java:
##########
@@ -489,6 +490,89 @@ private String getPartitionOffsetStr(Map<Long, String>
partitionNameByIds) {
return "[" + String.join(",", partitionOffsetStrs) + "]";
}
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ void testTieringForNestedRow(boolean isPrimaryKeyTable) throws Exception {
Review Comment:
> The IT cases are already quite heavy. This PR adds two new IT cases, but
we should avoid introducing additional ones if we can reuse existing tests
instead.
>
> In particular, it would be more efficient to add the new row-based test
scenarios directly into `FlinkUnionReadPrimaryKeyTableITCase` by simply
introducing a new field. This approach adds minimal overhead to test execution
time while keeping the test suite lean.
>
> For reference, see how this was done in: #2166.
Okay, I'll make the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
