buvb commented on PR #2189:
URL: https://github.com/apache/fluss/pull/2189#issuecomment-3694656438
@wuchong,
Thank you so much for reviewing, rebasing the branch, and fixing the
remaining issues before merging! I really appreciate your help and patience.
I apologize for not fully implementing all the review comments in my
commits. I encountered some integration test failures on my local environment
that prevented me from running the full test suite successfully. That's why
some of the improvements (like the complete null-safe comment comparison and
the shouldAlterTable() logic) were incomplete in my submission. I should have
communicated this issue earlier.
Thank you for stepping in and completing the implementation.
Regarding the git workflow: no more git merge, use git rebase instead.
This will keep the commit history cleaner and easier to track.
Best regards,
buvb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
