rionmonster commented on code in PR #2265:
URL: https://github.com/apache/fluss/pull/2265#discussion_r2650110260
##########
fluss-lake/fluss-lake-iceberg/src/test/java/org/apache/fluss/lake/iceberg/maintenance/IcebergRewriteITCase.java:
##########
@@ -186,6 +186,9 @@ void testLogTableCompaction() throws Exception {
t1, t1Bucket, ++i, true,
Collections.singletonList(row(1, "v1"))));
checkFileStatusInIcebergTable(t1, 3, false);
+ // Ensure tiering job has fully processed the previous writes
+ assertReplicaStatus(t1Bucket, i);
Review Comment:
@luoyuxia
I agree that it’s a bit odd. The additional replica assertion seems to
alleviate any race conditions within this specific test case that we were
seeing arise within the failing CI instances (at least based on my local
testing to reproduce the issue).
It may simply be a testing artifact as opposed to a legitimate issue, but if
it doesn’t seem like a fix, we can explore a few other avenues. It seemed like
one of those common race conditions, so leveraging an existing function to help
seemed like a decent approach. Happy to explore some additional avenues though,
if we feel that we need a bit more exhaustive checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
