luoyuxia commented on issue #118: URL: https://github.com/apache/fluss-rust/issues/118#issuecomment-3698017211
> Just to confirm, I should only submit the `CompactedRowWriter` for this task? It depends on the `CompactedRow` as well isn't it? So should I raise the PR for [#110](https://github.com/apache/fluss-rust/issues/110) firstly? Yes, you should only submit the `CompactedRowWriter` for this task. I think `CompactedRow` depends on `CompactedRowWriter` since `CompactedRowWriter` is write bytes in compacted way, and `CompactedRow` is to parse the bytes to row value. But anyway, it depends on you since you're the code developer. Feel free to take ways that's convenient for you . > Also, for the design, should the writer own the buffer like the Java implementation? Or it should just borrow it and own the "view" of the bytes. I think the writer own the buffer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
