wuchong commented on issue #2270:
URL: https://github.com/apache/fluss/issues/2270#issuecomment-3702116376
Since `sys.set_cluster_config` hasn’t been released yet, we still have the
opportunity to refine its design.
I propose introducing a **dedicated `sys.reset_cluster_configs`** procedure
specifically for resetting cluster configuration(s)—mirroring the pattern used
in SQL with `ALTER TABLE ... RESET`, which clearly signals intent and avoids
overloading `SET` with reset semantics.
Additionally, to better reflect that these procedures support **multiple
keys**, we should rename all related procedures from the singular
`xx_cluster_config` to the plural form **`xx_cluster_configs`** (e.g.,
`set_cluster_configs`, `reset_cluster_configs`). This aligns with common
conventions and improves API clarity.
This change would make the system more consistent, intuitive, and
forward-compatible.
```
-- Get all cluster configurations
CALL sys.get_cluster_configs();
-- Get a specific configuration
CALL sys.get_cluster_configs(
'kv.rocksdb.shared-rate-limiter.bytes-per-sec'
);
-- Get multiple configurations
CALL sys.get_cluster_configs(
'kv.rocksdb.shared-rate-limiter.bytes-per-sec',
'datalake.format'
);
-- Set RocksDB rate limiter to 200MB
CALL sys.set_cluster_config(
'kv.rocksdb.shared-rate-limiter.bytes-per-sec',
'200MB'
);
-- Set multiple configurations at one time
CALL sys.set_cluster_configs(
'kv.rocksdb.shared-rate-limiter.bytes-per-sec', '200MB',
'kv.snapshot.interval', '3min'
);
-- Reset a configuration (reset to default)
CALL sys.reset_clulster_configs(
'kv.rocksdb.shared-rate-limiter.bytes-per-sec'
);
-- Reset multiple configurations at one time
CALL sys.reset_clulster_configs(
'kv.rocksdb.shared-rate-limiter.bytes-per-sec',
'kv.snapshot.interval'
);
```
What do you think? @sd4324530 @platinumhamburg @loserwang1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
