wuchong commented on PR #2288: URL: https://github.com/apache/fluss/pull/2288#issuecomment-3702131985
Thanks for the contribution, @hemanthsavasere! However, the current implementation duplicates a significant amount of `ArrowWriter` logic that’s already implemented in `fluss-common`. This duplication creates substantial maintenance overhead for the community: as we add support for more data types or fix bugs in the `ArrowWriter` within `fluss-common`, those improvements and fixes won’t automatically propagate to the `fluss-lance` module, making it hard to keep both in sync. To ensure long-term maintainability and consistency, could we **first refactor the Arrow writer in `fluss-lance` to directly reuse the Arrow utilities from `fluss-common`**? Once that’s in place, we can safely proceed with adding complex type support for Lance on a solid, shared foundation. This approach will reduce redundancy, minimize future drift, and make contributions easier to sustain across modules. What do you think? @hemanthsavasere @xx789633 @luoyuxia @leonardBang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
