platinumhamburg commented on PR #2282: URL: https://github.com/apache/fluss/pull/2282#issuecomment-3704620316
> BucketMetricGroup @wuchong Thank you for your review comments. I’ll provide a detailed explanation of why I designed it this way. Initially, I decoupled RocksDB metrics from the bucket lifecycle for two main reasons: We do not intend to collect, register, or report RocksDB monitoring metrics at the bucket granularity. Since BucketMetricGroup is specifically designed to manage bucket-level metrics, from a perspective of functional consistency, it was not appropriate to associate RocksDB metrics with BucketMetricGroup. In practice, for primary key tables, the lifecycle of a KvTablet does not align with that of a bucket. The BucketMetricGroup is only unregistered when StopReplica is called, whereas the KvTablet must unregister its metric group as soon as it transitions to a follower role. Therefore, the lifecycle of KvTablet-related metrics should be tied to the KvTablet itself, not to the bucket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
