platinumhamburg commented on code in PR #2279: URL: https://github.com/apache/fluss/pull/2279#discussion_r2663275447
########## website/docs/engine-flink/procedures.md: ########## @@ -236,20 +236,51 @@ CALL [catalog_name.]sys.set_cluster_config(config_key => 'STRING') USE fluss_catalog; -- Set RocksDB rate limiter -CALL sys.set_cluster_config( - config_key => 'kv.rocksdb.shared-rate-limiter.bytes-per-sec', - config_value => '200MB' +CALL sys.set_cluster_configs( + config_pairs => 'kv.rocksdb.shared-rate-limiter.bytes-per-sec', '200MB' ); --- Set datalake format -CALL sys.set_cluster_config( - config_key => 'datalake.format', - config_value => 'paimon' +-- Set RocksDB rate limiter and datalake format +CALL sys.set_cluster_configs( + config_pairs => 'kv.rocksdb.shared-rate-limiter.bytes-per-sec', '200MB', 'datalake.format','paimon' ); +``` --- Delete a configuration (reset to default) -CALL sys.set_cluster_config( - config_key => 'kv.rocksdb.shared-rate-limiter.bytes-per-sec' -); +### reset_cluster_configs + +reset cluster configurations dynamically. + +**Syntax:** + +```sql +-- reset configuration values +CALL [catalog_name.]sys.reset_cluster_configs(config_keys => 'key1' [, 'key2', ...]) ``` +**Parameters:** + +- `config_keys`(required): The configuration keys to reset. + +**Important Notes:** + +- Changes are validated before being applied and persisted in ZooKeeper +- Changes are automatically applied to all servers (Coordinator and TabletServers) +- Changes survive server restarts Review Comment: This short description would be better placed in the set_cluster_configs section. ########## website/docs/engine-flink/procedures.md: ########## @@ -236,20 +236,51 @@ CALL [catalog_name.]sys.set_cluster_config(config_key => 'STRING') USE fluss_catalog; -- Set RocksDB rate limiter -CALL sys.set_cluster_config( - config_key => 'kv.rocksdb.shared-rate-limiter.bytes-per-sec', - config_value => '200MB' +CALL sys.set_cluster_configs( + config_pairs => 'kv.rocksdb.shared-rate-limiter.bytes-per-sec', '200MB' ); --- Set datalake format -CALL sys.set_cluster_config( - config_key => 'datalake.format', - config_value => 'paimon' +-- Set RocksDB rate limiter and datalake format +CALL sys.set_cluster_configs( + config_pairs => 'kv.rocksdb.shared-rate-limiter.bytes-per-sec', '200MB', 'datalake.format','paimon' ); +``` --- Delete a configuration (reset to default) -CALL sys.set_cluster_config( - config_key => 'kv.rocksdb.shared-rate-limiter.bytes-per-sec' -); +### reset_cluster_configs + +reset cluster configurations dynamically. + +**Syntax:** + +```sql +-- reset configuration values +CALL [catalog_name.]sys.reset_cluster_configs(config_keys => 'key1' [, 'key2', ...]) ``` +**Parameters:** + +- `config_keys`(required): The configuration keys to reset. + +**Important Notes:** + +- Changes are validated before being applied and persisted in ZooKeeper Review Comment: The description here is still a bit odd, because the user isn't trying to set a new value—they're simply reverting to the default configuration, which should always be valid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
