leekeiabstraction commented on code in PR #124:
URL: https://github.com/apache/fluss-rust/pull/124#discussion_r2668120088
##########
crates/fluss/src/row/mod.rs:
##########
@@ -78,6 +82,7 @@ pub struct GenericRow<'a> {
pub values: Vec<Datum<'a>>,
}
+// TODO Decide if migrate to Result<?>
Review Comment:
This is a duplicate TODO message, I've removed it.
Basically currently CompactedRowWriter / BinaryWriterTrait does not return
Result<>. I can make this change in future PR to improve error handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
