platinumhamburg commented on code in PR #1452:
URL: https://github.com/apache/fluss/pull/1452#discussion_r2670578775
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessor.java:
##########
@@ -848,13 +848,31 @@ private void processDeleteReplicaResponseReceived(
coordinatorContext.retryDeleteAndSuccessDeleteReplicas(failDeletedReplicas);
// transmit to deletion started for retry delete replicas
- replicaStateMachine.handleStateChanges(
- retryDeleteAndSuccessDeleteReplicas.f0,
ReplicaDeletionStarted);
+ Set<TableBucketReplica> needRetryDeleteReplicas = new HashSet<>();
+ retryDeleteAndSuccessDeleteReplicas.f0.forEach(
+ (replica) -> {
+ // For rebalance case. the replica state already set to
null in method
+ // stopRemovedReplicasOfReassignedBucket. so we need not
reset it again.
+ if (coordinatorContext.getReplicaState(replica) != null) {
Review Comment:
It seems that null is a very ambiguous state—would it be better to define a
clear, explicit state for use in rebalance scenarios?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
