Prajwal-banakar opened a new pull request, #2337:
URL: https://github.com/apache/fluss/pull/2337
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #2315
The purpose of this change is to enhance the unit test suite for the cluster
rebalancing module. This ensures that the system accurately calculates cluster
statistics and correctly generates optimization plans during critical lifecycle
events such as nodes joining or leaving the cluster.
### Brief change log
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
This PR introduces comprehensive test coverage for the following rebalance
components:
ServerModel: Added exhaustive tests for equals, hashCode, and compareTo to
ensure server identity is consistent across different cluster states.
ClusterModelStats: Implemented scenarios for empty clusters and highly
skewed clusters to verify the precision of statistical calculations (Mean, Max,
Min, and Standard Deviation).
GoalOptimizer: Added integration-style unit tests to simulate Node Join,
Node Leave (Offline), and Constraint Violation scenarios, ensuring rebalance
plans are generated as expected.
ReplicaDistributionGoal: Refactored testDoOptimizeWithOfflineServer to use
range-based assertions. This accounts for replica placement constraints,
ensuring tests are robust even when a "perfect" mathematical distribution is
prevented by duplicate replica rules.
### Tests
<!-- List UT and IT cases to verify this change -->
Verified the changes by running the following unit tests in the fluss-server
module:
org.apache.fluss.server.coordinator.rebalance.model.ServerModelTest
org.apache.fluss.server.coordinator.rebalance.model.ClusterModelStatsTest
org.apache.fluss.server.coordinator.rebalance.goal.GoalOptimizerTest
org.apache.fluss.server.coordinator.rebalance.goal.ReplicaDistributionGoalTest
The entire fluss-server test suite was executed locally and passed with
BUILD SUCCESS.
### API and Format
<!-- Does this change affect API or storage format -->
This change does not affect any public APIs.
Code formatting has been verified and applied using mvn spotless:apply.
### Documentation
<!-- Does this change introduce a new feature -->
This change does not introduce new features; no documentation updates are
required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
