wuchong commented on code in PR #2314: URL: https://github.com/apache/fluss/pull/2314#discussion_r2679360070
########## fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkDDLPartitionTest.scala: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.spark + +import org.apache.fluss.metadata.PartitionSpec + +import org.apache.spark.sql.Row + +import scala.collection.JavaConverters._ + +class SparkDDLPartitionTest extends FlussSparkTestBase { Review Comment: We don't need a separate test class for partition DDL, otherwise, we will have a lot of test class when we support all the DDLs and DMLs. Could you move the tests into `FlussCatalogTest`? And maybe we can rename `FlussCatalogTest` to `SparkCatalogTest` to align with `FlinkCatalogTest`. ########## fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkDDLPartitionTest.scala: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.spark + +import org.apache.fluss.metadata.PartitionSpec + +import org.apache.spark.sql.Row + +import scala.collection.JavaConverters._ + +class SparkDDLPartitionTest extends FlussSparkTestBase { + + test("show partitions") { + withCurrentCatalogAndNamespace { + withTable("t") { + sql(s"CREATE TABLE t (id int, name string, pt1 string, pt2 int) PARTITIONED BY (pt1, pt2)") Review Comment: Could you also `checkAnswer` for `DESC` this partitioned table? Since we only cover DESC for a non-partitioned table in `Catalog: basic table` test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
