swuferhong commented on code in PR #2341: URL: https://github.com/apache/fluss/pull/2341#discussion_r2680717741
########## fluss-server/src/test/java/org/apache/fluss/server/coordinator/rebalance/RebalanceManagerTest.java: ########## @@ -31,9 +31,9 @@ import org.apache.fluss.server.zk.NOPErrorHandler; import org.apache.fluss.server.zk.ZooKeeperClient; import org.apache.fluss.server.zk.ZooKeeperExtension; -import org.apache.fluss.server.zk.data.RebalanceTask; import org.apache.fluss.testutils.common.AllCallbackWrapper; import org.apache.fluss.utils.concurrent.ExecutorThreadFactory; +import org.apache.fluss.utils.json.RebalanceTask; Review Comment: Why we need move this class? ########## fluss-common/src/main/java/org/apache/fluss/utils/json/RebalancePlanForBucketJsonSerde.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.utils.json; + +import org.apache.fluss.cluster.rebalance.RebalancePlanForBucket; +import org.apache.fluss.metadata.TableBucket; +import org.apache.fluss.shaded.jackson2.com.fasterxml.jackson.core.JsonGenerator; +import org.apache.fluss.shaded.jackson2.com.fasterxml.jackson.databind.JsonNode; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; + +/** Json serializer and deserializer for {@link RebalancePlanForBucket}. */ +public class RebalancePlanForBucketJsonSerde + implements JsonSerializer<RebalancePlanForBucket>, + JsonDeserializer<RebalancePlanForBucket> { + + public static final RebalancePlanForBucketJsonSerde INSTANCE = + new RebalancePlanForBucketJsonSerde(); + + private static final String VERSION_KEY = "version"; + private static final int VERSION = 1; Review Comment: There's no need to add the version parameter here. We primarily add the version for ZooKeeper compatibility; serialization of a plain rebalance plan doesn't require it. ########## fluss-common/src/main/java/org/apache/fluss/utils/json/RebalancePlanForBucketJsonSerde.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.utils.json; + +import org.apache.fluss.cluster.rebalance.RebalancePlanForBucket; +import org.apache.fluss.metadata.TableBucket; +import org.apache.fluss.shaded.jackson2.com.fasterxml.jackson.core.JsonGenerator; +import org.apache.fluss.shaded.jackson2.com.fasterxml.jackson.databind.JsonNode; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; + +/** Json serializer and deserializer for {@link RebalancePlanForBucket}. */ +public class RebalancePlanForBucketJsonSerde Review Comment: `RebalancePlanForBucketJsonSerde` cannot fully represent the content of `RebalanceResultForBucket`. Maybe we need define a new `RebalanceResultForBucketJsonSerde` instead, so it can include the execution status of an individual bucket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
