fresh-borzoni commented on code in PR #150:
URL: https://github.com/apache/fluss-rust/pull/150#discussion_r2694777692


##########
bindings/python/src/admin.rs:
##########
@@ -96,6 +96,104 @@ impl FlussAdmin {
         })
     }
 
+    /// Drop a table
+    #[pyo3(signature = (table_path, ignore_if_not_exists=false))]
+    pub fn drop_table<'py>(
+        &self,
+        py: Python<'py>,
+        table_path: &TablePath,
+        ignore_if_not_exists: bool,
+    ) -> PyResult<Bound<'py, PyAny>> {
+        let core_table_path = table_path.to_core();

Review Comment:
   well, the other way around. 
   to_core already returns owned copy. I'll cleanup other occurences, np



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to