luoyuxia commented on code in PR #151:
URL: https://github.com/apache/fluss-rust/pull/151#discussion_r2696538596
##########
bindings/python/src/table.rs:
##########
@@ -126,6 +157,102 @@ impl FlussTable {
has_primary_key,
}
}
+
+ /// Validate and deduplicate column indices (preserving order)
+ fn validate_and_dedupe_indices(&self, indices: &[usize]) ->
PyResult<Vec<usize>> {
Review Comment:
Since the rust code will do the validation, maybe we can remove the
validation in here?
Aslo may be we don't need to do deduplicate since java side also allows
deduplicate columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
