sd4324530 commented on issue #2384:
URL: https://github.com/apache/fluss/issues/2384#issuecomment-3757760779
> > Similarly, could `AddServerTagProcedure` and `RemoveServerTagProcedure`
also be refactored to look like this:
> > CALL sys.add_server_tags('PERMANENT_OFFLINE', '1', '2', '3');
> > CALL sys.remove_server_tags('TEMPORARY_OFFLINE', '1', '2', '3');
> >
> > 1. The name becomes `add_server_tags` and `remove_server_tags`
> > 2. `tabletServers` becomes the first parameter, and `serverTag` becomes
a variable-length parameter.
> > [@swuferhong](https://github.com/swuferhong) What do you think?
>
> I don't think variable-length parameters are a good solution. This would
make our procedures very difficult to extend - adding new parameters would
create significant compatibility issues. It would be better to wait until
Flink's call procedure supports row or array types. I will close this issue.
Thanks [@sd4324530](https://github.com/sd4324530)
@swuferhong Thank you for your reply. When I was working on my previous pull
request, I discovered that Flink 1.19+ supports array parameters. See
https://github.com/apache/fluss/issues/2270#issuecomment-3696945175. The
parameter can also be written as `String[]`
I think we can reconsider this when Fluss no longer supports Flink 1.18.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
