leekeiabstraction commented on code in PR #169:
URL: https://github.com/apache/fluss-rust/pull/169#discussion_r2704491856
##########
crates/fluss/src/client/table/writer.rs:
##########
@@ -32,10 +33,10 @@ pub trait AppendWriter: TableWriter {
async fn append(&self, row: GenericRow) -> Result<()>;
}
-#[allow(dead_code)]
+#[allow(dead_code, async_fn_in_trait)]
pub trait UpsertWriter: TableWriter {
- async fn upsert(&self, row: GenericRow) -> Result<()>;
- async fn delete(&self, row: GenericRow) -> Result<()>;
+ async fn upsert(&mut self, row: CompactedRow) -> Result<()>;
Review Comment:
Yes, the compiler in this case infers it to be anonymous lifetime `_`. I can
make it explicity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
