Prajwal-banakar opened a new pull request, #2416:
URL: https://github.com/apache/fluss/pull/2416
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #2344
<!-- What is the purpose of the change -->
The purpose of this change is to refactor the SchemaUpdate class to delegate
all schema membership management (columns, primary keys, and auto-increment
fields) directly to Schema.Builder. Currently, SchemaUpdate manually maintains
these members, which is error-prone and can lead to broken schemas during
evolution.
### Brief change log
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
Refactored SchemaUpdate: Removed local lists for columns, primary keys, and
auto-increment fields.
Builder Delegation: Modified SchemaUpdate to directly maintain a
Schema.Builder instance, ensuring a single source of truth for schema building
and validation logic.
Enhanced Schema.Builder: Updated Schema.Builder#fromSchema to correctly
adopt all members from an existing schema, including column IDs and metadata.
Added Helper API: Added Schema.Builder#getColumn(String columnName) to allow
checking for existing columns within the builder's state.
### Tests
<!-- List UT and IT cases to verify this change -->
Verified the fix by running TableSchemaTest and SchemaUpdateTest to ensure
the delegation logic handles schema evolution correctly without
IllegalStateException.
Performed a full test suite execution for the fluss-common module: mvn test
-pl fluss-common.
Results: 1,491 tests run, 0 failures.
### API and Format
<!-- Does this change affect API or storage format -->
This change adds a public helper method getColumn(String columnName) to the
Schema.Builder API.
It does not affect the storage format.
### Documentation
<!-- Does this change introduce a new feature -->
This change does not introduce a new feature; it is a refactoring of
existing internal logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
