luoyuxia commented on code in PR #181: URL: https://github.com/apache/fluss-rust/pull/181#discussion_r2708827022
########## crates/examples/src/example_kv_table.rs: ########## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use clap::Parser; +use fluss::client::{FlussConnection, TableWriter, UpsertWriter}; +use fluss::config::Config; +use fluss::error::Result; +use fluss::metadata::{DataTypes, Schema, TableDescriptor, TablePath}; +use fluss::row::{GenericRow, InternalRow}; + +#[tokio::main] +#[allow(dead_code)] Review Comment: do we need this? Seem `example_table` doesn't have it. ########## crates/examples/src/example_kv_table.rs: ########## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use clap::Parser; +use fluss::client::{FlussConnection, TableWriter, UpsertWriter}; +use fluss::config::Config; +use fluss::error::Result; +use fluss::metadata::{DataTypes, Schema, TableDescriptor, TablePath}; +use fluss::row::{GenericRow, InternalRow}; + +#[tokio::main] +#[allow(dead_code)] +pub async fn main() -> Result<()> { + let mut config = Config::parse(); + config.bootstrap_server = Some("127.0.0.1:9123".to_string()); + + let conn = FlussConnection::new(config).await?; + + let table_descriptor = TableDescriptor::builder() + .schema( + Schema::builder() + .column("id", DataTypes::int()) + .column("name", DataTypes::string()) + .column("age", DataTypes::bigint()) + .primary_key(vec!["id".to_string()]) + .build()?, + ) + .build()?; + + let table_path = TablePath::new("fluss".to_owned(), "rust_upsert_lookup_example".to_owned()); + + let admin = conn.get_admin().await?; + admin + .create_table(&table_path, &table_descriptor, true) + .await?; + println!( + "Created KV Table:\n {}\n", + admin.get_table(&table_path).await? + ); + + let table = conn.get_table(&table_path).await?; + let table_upsert = table.new_upsert()?; + let mut upsert_writer = table_upsert.create_writer()?; + + println!("\n=== Upserting ==="); + for (id, name, age) in [(1, "Verso", 32i64), (2, "Noco", 25), (3, "Esquie", 35)] { + let mut row = GenericRow::new(); + row.set_field(0, id); + row.set_field(1, name); + row.set_field(2, age); + upsert_writer.upsert(&row).await?; + println!("Upserted: {row:?}"); + } + upsert_writer.flush().await?; Review Comment: nit: if we alreay await `upsert_writer.upsert(&row)`, we won't need to flush in here. ########## crates/examples/src/example_kv_table.rs: ########## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use clap::Parser; +use fluss::client::{FlussConnection, TableWriter, UpsertWriter}; +use fluss::config::Config; +use fluss::error::Result; +use fluss::metadata::{DataTypes, Schema, TableDescriptor, TablePath}; +use fluss::row::{GenericRow, InternalRow}; + +#[tokio::main] +#[allow(dead_code)] +pub async fn main() -> Result<()> { + let mut config = Config::parse(); + config.bootstrap_server = Some("127.0.0.1:9123".to_string()); + + let conn = FlussConnection::new(config).await?; + + let table_descriptor = TableDescriptor::builder() + .schema( + Schema::builder() + .column("id", DataTypes::int()) + .column("name", DataTypes::string()) + .column("age", DataTypes::bigint()) + .primary_key(vec!["id".to_string()]) + .build()?, + ) + .build()?; + + let table_path = TablePath::new("fluss".to_owned(), "rust_upsert_lookup_example".to_owned()); + + let admin = conn.get_admin().await?; + admin + .create_table(&table_path, &table_descriptor, true) + .await?; + println!( + "Created KV Table:\n {}\n", + admin.get_table(&table_path).await? + ); + + let table = conn.get_table(&table_path).await?; + let table_upsert = table.new_upsert()?; + let mut upsert_writer = table_upsert.create_writer()?; + + println!("\n=== Upserting ==="); + for (id, name, age) in [(1, "Verso", 32i64), (2, "Noco", 25), (3, "Esquie", 35)] { + let mut row = GenericRow::new(); + row.set_field(0, id); + row.set_field(1, name); + row.set_field(2, age); + upsert_writer.upsert(&row).await?; + println!("Upserted: {row:?}"); + } + upsert_writer.flush().await?; + + println!("\n=== Looking up ==="); + let mut lookuper = table.new_lookup()?.create_lookuper()?; + + for id in 1..=2 { + let result = lookuper.lookup(&make_key(id)).await?; + let row = result.get_single_row()?.unwrap(); + println!( + "Found id={id}: name={}, age={}", + row.get_string(1), + row.get_long(2) + ); + } + + println!("\n=== Updating ==="); + let mut row = GenericRow::new(); + row.set_field(0, 1); + row.set_field(1, "Verso"); + row.set_field(2, 33i64); + upsert_writer.upsert(&row).await?; + upsert_writer.flush().await?; + println!("Updated: {row:?}"); + + let result = lookuper.lookup(&make_key(1)).await?; + let row = result.get_single_row()?.unwrap(); + println!( + "Verified update: name={}, age={}", + row.get_string(1), + row.get_long(2) + ); + + println!("\n=== Deleting ==="); + let mut row = GenericRow::new(); Review Comment: I found even for delete, we have to fill the non-primary key field. So, I'm wondering can we introduce a method such as `GenericRow::new(field_count: usize)` just like java side. The default is null, but user can set the field. Then, for delete, users just need to ``` let mut row = GenericRow::new(3); row.set_field(0, 2) ``` WDYT? ########## crates/examples/src/example_kv_table.rs: ########## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use clap::Parser; +use fluss::client::{FlussConnection, TableWriter, UpsertWriter}; +use fluss::config::Config; +use fluss::error::Result; +use fluss::metadata::{DataTypes, Schema, TableDescriptor, TablePath}; +use fluss::row::{GenericRow, InternalRow}; + +#[tokio::main] +#[allow(dead_code)] +pub async fn main() -> Result<()> { + let mut config = Config::parse(); + config.bootstrap_server = Some("127.0.0.1:9123".to_string()); + + let conn = FlussConnection::new(config).await?; + + let table_descriptor = TableDescriptor::builder() + .schema( + Schema::builder() + .column("id", DataTypes::int()) + .column("name", DataTypes::string()) + .column("age", DataTypes::bigint()) + .primary_key(vec!["id".to_string()]) + .build()?, + ) + .build()?; + + let table_path = TablePath::new("fluss".to_owned(), "rust_upsert_lookup_example".to_owned()); + + let admin = conn.get_admin().await?; + admin + .create_table(&table_path, &table_descriptor, true) + .await?; + println!( + "Created KV Table:\n {}\n", + admin.get_table(&table_path).await? + ); + + let table = conn.get_table(&table_path).await?; + let table_upsert = table.new_upsert()?; + let mut upsert_writer = table_upsert.create_writer()?; + + println!("\n=== Upserting ==="); + for (id, name, age) in [(1, "Verso", 32i64), (2, "Noco", 25), (3, "Esquie", 35)] { + let mut row = GenericRow::new(); + row.set_field(0, id); + row.set_field(1, name); + row.set_field(2, age); + upsert_writer.upsert(&row).await?; + println!("Upserted: {row:?}"); + } + upsert_writer.flush().await?; + + println!("\n=== Looking up ==="); + let mut lookuper = table.new_lookup()?.create_lookuper()?; + + for id in 1..=2 { + let result = lookuper.lookup(&make_key(id)).await?; + let row = result.get_single_row()?.unwrap(); + println!( + "Found id={id}: name={}, age={}", + row.get_string(1), + row.get_long(2) + ); + } + + println!("\n=== Updating ==="); + let mut row = GenericRow::new(); + row.set_field(0, 1); + row.set_field(1, "Verso"); + row.set_field(2, 33i64); + upsert_writer.upsert(&row).await?; + upsert_writer.flush().await?; Review Comment: dito ########## crates/examples/src/example_kv_table.rs: ########## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use clap::Parser; +use fluss::client::{FlussConnection, TableWriter, UpsertWriter}; +use fluss::config::Config; +use fluss::error::Result; +use fluss::metadata::{DataTypes, Schema, TableDescriptor, TablePath}; +use fluss::row::{GenericRow, InternalRow}; + +#[tokio::main] +#[allow(dead_code)] +pub async fn main() -> Result<()> { + let mut config = Config::parse(); + config.bootstrap_server = Some("127.0.0.1:9123".to_string()); + + let conn = FlussConnection::new(config).await?; + + let table_descriptor = TableDescriptor::builder() + .schema( + Schema::builder() + .column("id", DataTypes::int()) + .column("name", DataTypes::string()) + .column("age", DataTypes::bigint()) + .primary_key(vec!["id".to_string()]) + .build()?, + ) + .build()?; + + let table_path = TablePath::new("fluss".to_owned(), "rust_upsert_lookup_example".to_owned()); + + let admin = conn.get_admin().await?; + admin + .create_table(&table_path, &table_descriptor, true) + .await?; + println!( + "Created KV Table:\n {}\n", + admin.get_table(&table_path).await? + ); + + let table = conn.get_table(&table_path).await?; + let table_upsert = table.new_upsert()?; + let mut upsert_writer = table_upsert.create_writer()?; + + println!("\n=== Upserting ==="); + for (id, name, age) in [(1, "Verso", 32i64), (2, "Noco", 25), (3, "Esquie", 35)] { + let mut row = GenericRow::new(); + row.set_field(0, id); + row.set_field(1, name); + row.set_field(2, age); + upsert_writer.upsert(&row).await?; + println!("Upserted: {row:?}"); + } + upsert_writer.flush().await?; + + println!("\n=== Looking up ==="); + let mut lookuper = table.new_lookup()?.create_lookuper()?; + + for id in 1..=2 { + let result = lookuper.lookup(&make_key(id)).await?; + let row = result.get_single_row()?.unwrap(); + println!( + "Found id={id}: name={}, age={}", + row.get_string(1), + row.get_long(2) + ); + } + + println!("\n=== Updating ==="); + let mut row = GenericRow::new(); + row.set_field(0, 1); + row.set_field(1, "Verso"); + row.set_field(2, 33i64); + upsert_writer.upsert(&row).await?; + upsert_writer.flush().await?; + println!("Updated: {row:?}"); + + let result = lookuper.lookup(&make_key(1)).await?; + let row = result.get_single_row()?.unwrap(); + println!( + "Verified update: name={}, age={}", + row.get_string(1), + row.get_long(2) + ); + + println!("\n=== Deleting ==="); + let mut row = GenericRow::new(); + row.set_field(0, 2); + row.set_field(1, ""); + row.set_field(2, 0i64); + upsert_writer.delete(&row).await?; + upsert_writer.flush().await?; Review Comment: dito -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
