wuchong opened a new pull request, #2429:
URL: https://github.com/apache/fluss/pull/2429
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
This pull request refactors snapshot-related test utilities across multiple
integration test cases to improve consistency and reliability. The main change
is replacing manual snapshot waiting logic and configuration with standardized
methods provided by `FLUSS_CLUSTER_EXTENSION`, and removing unnecessary
configuration of snapshot intervals for testing purposes.
**Snapshot Triggering and Waiting Refactor:**
* Replaced calls to custom snapshot waiting methods (e.g.,
`waitUntilAllSnapshotFinished`, `waitUntilSnapshotFinished`, and
`waitUntilAllBucketFinishSnapshot`) with standardized calls to
`FLUSS_CLUSTER_EXTENSION.triggerAndWaitSnapshot` and
`FLUSS_CLUSTER_EXTENSION.triggerAndWaitSnapshots` in test cases such as
`FlinkTableSourceITCase`, `KvSnapshotBatchScannerITCase`, and
`FlussAdminITCase`. This improves test reliability and code maintainability.
**Configuration Cleanup:**
* Removed test-specific configuration for snapshot intervals
(`KV_SNAPSHOT_INTERVAL`) from cluster configuration initialization in several
test classes, relying instead on default settings and explicit snapshot
triggering. This reduces test configuration complexity and potential flakiness.
**Code Simplification:**
* Removed unused imports and redundant utility methods related to snapshot
waiting, such as `waitUntilAllSnapshotFinished` and
`waitUntilAllBucketFinishSnapshot`, further streamlining test code.
Overall, these changes standardize snapshot handling in tests, reduce
configuration overhead, and simplify the codebase, making the tests easier to
maintain and less error-prone.
<!-- What is the purpose of the change -->
### Brief change log
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
