leekeiabstraction commented on code in PR #196:
URL: https://github.com/apache/fluss-rust/pull/196#discussion_r2716603781
##########
crates/fluss/src/row/datum.rs:
##########
@@ -298,16 +450,297 @@ impl Datum<'_> {
Datum::Float64(v) => append_value_to_arrow!(Float64Builder,
v.into_inner()),
Datum::String(v) => append_value_to_arrow!(StringBuilder,
v.as_ref()),
Datum::Blob(v) => append_value_to_arrow!(BinaryBuilder,
v.as_ref()),
- Datum::Decimal(_)
- | Datum::Date(_)
- | Datum::Time(_)
- | Datum::TimestampNtz(_)
- | Datum::TimestampLtz(_) => {
+ Datum::Decimal(decimal) => {
Review Comment:
Should we have test cases for these on both rust and Java side to ensure
parity?
Also, could arrow's rust library already be handling these (on Java side, we
do use arrow's library).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
