luoyuxia commented on code in PR #192: URL: https://github.com/apache/fluss-rust/pull/192#discussion_r2716948068
########## crates/fluss/tests/integration/kv_table.rs: ########## @@ -0,0 +1,637 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +use parking_lot::RwLock; +use std::sync::Arc; +use std::sync::LazyLock; + +use crate::integration::fluss_cluster::FlussTestingCluster; +#[cfg(test)] +use test_env_helpers::*; + +// Module-level shared cluster instance (only for this test file) +static SHARED_FLUSS_CLUSTER: LazyLock<Arc<RwLock<Option<FlussTestingCluster>>>> = + LazyLock::new(|| Arc::new(RwLock::new(None))); + +#[cfg(test)] +#[before_all] +#[after_all] +mod kv_table_test { + use super::SHARED_FLUSS_CLUSTER; + use crate::integration::fluss_cluster::FlussTestingCluster; + use crate::integration::utils::{create_table, get_cluster, start_cluster, stop_cluster}; + use fluss::client::UpsertWriter; + use fluss::metadata::{DataTypes, Schema, TableDescriptor, TablePath}; + use fluss::row::{GenericRow, InternalRow}; + use std::sync::Arc; + + fn before_all() { + start_cluster("test_kv_table", SHARED_FLUSS_CLUSTER.clone()); + } + + fn get_fluss_cluster() -> Arc<FlussTestingCluster> { + get_cluster(&SHARED_FLUSS_CLUSTER) + } + + fn after_all() { + stop_cluster(SHARED_FLUSS_CLUSTER.clone()); + } + + fn make_key(id: i32) -> GenericRow<'static> { + let mut row = GenericRow::new(); + row.set_field(0, id); + row + } + + #[tokio::test] + async fn upsert_and_lookup() { Review Comment: Can we just combine these to one or less test methods? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
