fresh-borzoni commented on issue #200:
URL: https://github.com/apache/fluss-rust/issues/200#issuecomment-3787988360

   Hi @zhaohaidao , thanks for raising this!
   
   I would call it - suboptimal code, but not strictly deadlock
   ```rust
   *result_clone.lock() = Some(download_result);
   ```
   
   I think lock() here would return MutexGuard that is only valid till 
semicolon since we don't have it captured in variable.
   Technically meaning that we unlock before acquiring completion_callbacks, so 
code is brittle, but correct.
   
   Worth fixing though


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to