affo commented on code in PR #2460:
URL: https://github.com/apache/fluss/pull/2460#discussion_r2720719141
##########
helm/templates/sts-coordinator.yaml:
##########
@@ -59,17 +59,28 @@ spec:
valueFrom:
fieldRef:
fieldPath: status.hostIP
+ ports:
+ - name: internal
+ containerPort: {{ .Values.listeners.internal.port }}
+ - name: client
+ containerPort: {{ .Values.listeners.client.port }}
+ {{- if .Values.externalAccess.enabled }}
+ - name: external
+ containerPort: {{ .Values.listeners.external.port }}
+ {{- end }}
Review Comment:
it seems this PR is not about any external listener 🤔
##########
helm/templates/sts-tablet.yaml:
##########
@@ -55,32 +55,45 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
+ ports:
+ - name: internal
+ containerPort: {{ .Values.listeners.internal.port }}
+ - name: client
+ containerPort: {{ .Values.listeners.client.port }}
+ {{- if .Values.externalAccess.enabled }}
+ - name: external
+ containerPort: {{ .Values.listeners.external.port }}
+ {{- end }}
Review Comment:
it seems this PR is not about any external listener 🤔
##########
website/docs/install-deploy/deploying-with-helm.md:
##########
@@ -184,8 +184,9 @@ The following table lists the configurable parameters of
the Fluss chart and the
| Parameter | Description | Default |
|-----------|-------------|---------|
-| `appConfig.internalPort` | Internal communication port | `9123` |
-| `appConfig.externalPort` | External client port | `9124` |
+| `listeners.internal.port` | Internal communication port | `9123` |
+| `listeners.client.port` | Client port (intra-cluster) | `9124` |
+| `listeners.external.port` | External access port | `9125` |
Review Comment:
it seems this PR is not about any external listener 🤔
##########
website/docs/install-deploy/deploying-with-helm.md:
##########
@@ -237,19 +238,20 @@ configurationOverrides:
The chart automatically configures listeners for internal cluster
communication and external client access:
-- **Internal Port (9123)**: Used for inter-service communication within the
cluster
-- **External Port (9124)**: Used for client connections
+- **Internal Port (9123)**: Used for internal communication within the cluster
+- **Client Port (9124)**: Used for client connections
+- **External Port (9125)**: Used for external access if enabled
Review Comment:
it seems this PR is not about any external listener 🤔
##########
website/docs/install-deploy/deploying-with-helm.md:
##########
@@ -237,19 +238,20 @@ configurationOverrides:
The chart automatically configures listeners for internal cluster
communication and external client access:
-- **Internal Port (9123)**: Used for inter-service communication within the
cluster
-- **External Port (9124)**: Used for client connections
+- **Internal Port (9123)**: Used for internal communication within the cluster
+- **Client Port (9124)**: Used for client connections
+- **External Port (9125)**: Used for external access if enabled
Custom listener configuration:
```yaml
-appConfig:
- internalPort: 9123
- externalPort: 9124
-
-configurationOverrides:
- bind.listeners: "INTERNAL://0.0.0.0:9123,CLIENT://0.0.0.0:9124"
- advertised.listeners: "CLIENT://my-cluster.example.com:9124"
+listeners:
+ internal:
+ port: 9123
+ client:
+ port: 9124
+ external:
+ port: 9125
Review Comment:
it seems this PR is not about any external listener 🤔
##########
helm/values.yaml:
##########
@@ -47,6 +42,23 @@ persistence:
size: 1Gi
storageClass:
+# Fluss listener configurations
+listeners:
+ internal:
+ name: INTERNAL
Review Comment:
I don't see the need to put the name here, as it is not used and hardcoded
in any case later
##########
helm/values.yaml:
##########
@@ -47,6 +42,23 @@ persistence:
size: 1Gi
storageClass:
+# Fluss listener configurations
+listeners:
+ internal:
+ name: INTERNAL
+ port: 9123
+ client:
+ name: CLIENT
+ port: 9124
+ ## Activated only when @param externalAccess.enabled is true
+ external:
+ name: EXTERNAL
+ port: 9125
+
+# Fluss cluster external access
+externalAccess:
+ enabled: false
Review Comment:
it seems this PR is not about any external listener 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
