luoyuxia commented on code in PR #205:
URL: https://github.com/apache/fluss-rust/pull/205#discussion_r2724754067
##########
crates/fluss/src/row/column.rs:
##########
@@ -253,16 +331,33 @@ impl InternalRow for ColumnarRow {
}
fn get_char(&self, pos: usize, _length: usize) -> &str {
- let array = self
- .record_batch
- .column(pos)
- .as_any()
- .downcast_ref::<FixedSizeBinaryArray>()
- .expect("Expected fixed-size binary array for char type");
+ let column = self.record_batch.column(pos);
+ let schema = self.record_batch.schema();
+ let arrow_field = schema.field(pos);
- let bytes = array.value(self.row_id);
- // don't check length, following java client
- std::str::from_utf8(bytes).expect("Invalid UTF-8 in char field")
+ match arrow_field.data_type() {
+ ArrowDataType::FixedSizeBinary(_) => {
+ // KV table format: char stored as FixedSizeBinary
Review Comment:
hi, what does it mean? Why said KV table format stored as FixedSizeBinary.
Do you mean change log for kv table format?
Shouldn't KV table format and Log table format use same tye for arrow change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
