Copilot commented on code in PR #211:
URL: https://github.com/apache/fluss-rust/pull/211#discussion_r2724757309
##########
crates/fluss/src/client/table/scanner.rs:
##########
@@ -433,7 +434,8 @@ impl LogScanner {
// Implementation for RecordBatchLogScanner (batches mode)
impl RecordBatchLogScanner {
- pub async fn poll(&self, timeout: Duration) -> Result<Vec<RecordBatch>> {
+ /// Poll for batches with metadata (bucket and offset information).
+ pub async fn poll(&self, timeout: Duration) -> Result<Vec<ScanBatch>> {
Review Comment:
The PR description states "No breaking changes" and describes this as an
"internal API" change. However, RecordBatchLogScanner and its poll() method are
part of the public API (exported in crates/fluss/src/client/table/mod.rs line
39). The return type change from Vec<RecordBatch> to Vec<ScanBatch>
is a breaking change that will affect any downstream consumers of this API,
including existing integration tests in crates/fluss/tests/integration/table.rs
that directly access methods on the returned batches. Consumers will need to
either call .batch() to get the RecordBatch reference or .into_batch() to
consume it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
