Copilot commented on code in PR #212:
URL: https://github.com/apache/fluss-rust/pull/212#discussion_r2725158996


##########
crates/fluss/tests/integration/table_remote_scan.rs:
##########
@@ -146,7 +146,7 @@ mod table_remote_scan_test {
         // append 20 rows, there must be some tiered to remote
         let record_count = 20;
         for i in 0..record_count {
-            let mut row = GenericRow::new();
+            let mut row = GenericRow::new(1);

Review Comment:
   `GenericRow::new(1)` allocates a row with only 1 field, but this test sets 
fields at positions 0 and 1. With the new `set_field` implementation 
(`self.values[pos] = ...`), `set_field(1, ...)` will panic (index out of 
bounds). Create the row with 2 fields to match the table schema (c1, c2).
   ```suggestion
               let mut row = GenericRow::new(2);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to