leekeiabstraction commented on code in PR #214:
URL: https://github.com/apache/fluss-rust/pull/214#discussion_r2727732744
##########
crates/fluss/src/client/admin.rs:
##########
@@ -140,7 +140,10 @@ impl FlussAdmin {
}
/// List all partitions in the given table.
- pub async fn list_partition_infos(&self, table_path: &TablePath) ->
Result<Vec<PartitionInfo>> {
+ pub async fn list_partition_infos(
+ &self,
+ table_path: &TablePath,
+ ) -> Result<Vec<PartitionInfo<'_>>> {
Review Comment:
PartitionInfo has lifetime param because ResolvedPartitionSpec has lifetime
param. This was added in response to Copilot's comment:
https://github.com/apache/fluss-rust/pull/214#discussion_r2725548055
The cloning of partition keys are what Copilot refers to in that comment.
LMK if you prefer cloning without lifetime param and I can revert.
Alternatively we can also leave it as elided here
```rust
pub async fn list_partition_infos(
&self,
table_path: &TablePath,
) -> Result<Vec<PartitionInfo>> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
