platinumhamburg opened a new pull request, #2492:
URL: https://github.com/apache/fluss/pull/2492
This commit introduces AggMode (Aggregation Mode) to control how the server
handles data aggregation when writing to tables with aggregation merge engine.
Key changes:
1. New AggMode enum with three modes:
- AGGREGATE (default): Data is aggregated through server-side merge engine
- OVERWRITE: Bypass merge engine, directly replace values (for undo
recovery)
- LOCAL_AGGREGATE: Reserved for future client-side pre-aggregation
2. Client-side changes:
- Upsert interface: Added aggregationMode(AggMode) method for fluent API
- UpsertWriterImpl: Propagates aggMode through WriteRecord
- KvWriteBatch: Validates aggMode consistency within batch
- ClientRpcMessageUtils: Validates aggMode consistency across batches
- WriteRecord: Added aggMode field for upsert/delete operations
3. Server-side changes:
- KvTablet: Pre-creates overwriteRowMerger for OVERWRITE mode
- putAsLeader(): Selects appropriate RowMerger based on aggMode
- Replica/ReplicaManager: Propagates aggMode through call chain
- TabletService: Extracts aggMode from PutKvRequest
4. Protocol changes:
- FlussApi.proto: Added optional agg_mode field to PutKvRequest
5. Test coverage:
- KvTabletAggModeTest: 9 tests covering OVERWRITE mode scenarios
- KvWriteBatchTest: 3 tests for aggMode consistency validation
- ClientRpcMessageUtilsTest: 4 tests for multi-batch aggMode validation
This feature enables Flink connector to perform undo recovery by restoring
exact historical values during checkpoint failover, bypassing the merge engine.
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #2491 2491
<!-- What is the purpose of the change -->
### Brief change log
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
