wuchong commented on code in PR #2434: URL: https://github.com/apache/fluss/pull/2434#discussion_r2731211202
########## fluss-common/src/main/java/org/apache/fluss/rpc/messages/RegisterResult.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.rpc.messages; + +import org.apache.fluss.annotation.PublicEvolving; + +/** + * Result of producer offset registration. + * + * <p>This enum indicates whether a producer offset snapshot was newly created or already existed + * when calling registerProducerOffsets API. + * + * @since 0.9 + */ +@PublicEvolving +public enum RegisterResult { Review Comment: Yes. We could also consider in the future which package under `fluss-common` would be the most appropriate place for `RegisterResult`. My main concern initially was simply that it doesn't belong in the `*.rpc.message` package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
