leonardBang commented on PR #2431: URL: https://github.com/apache/fluss/pull/2431#issuecomment-3804646220
> @LiebingYu thank you, I think you raised a good point that tables created via other platforms (e.g., Spark or the SDK) aren’t subject to this restriction and may include arbitrary options, which could cause Flink reads to fail. > > Therefore, I agree with removing the broad validation like `helper.validateExcept` and instead only validating the options explicitly recognized by this connector—for example, using `FlinkConnectorOptionsUtils#validateTableSourceOptions`. > > Additionally, I still recommend that platforms use a dedicated prefix such as `tags.*` for custom metadata. This reduces the risk of naming conflicts with other engines and simplifies maintenance by allowing platform-level options to be easily identified and filtered by prefix. > > What do you think @leonardBang @loserwang1024 ? After discussed with Jark offline, we think Fluss' case is different with Kafka connector as Kakfa Connector does not maintain Table properties but Fluss does. As the custom table properties maybe injected from different computing engine like Flink, Spark and StarRocks when user user these engine to create Fluss table, removing these validation looks necessary for cross different engine user case and backward compatibility for cross different engine versions user case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
