luoyuxia commented on code in PR #2464:
URL: https://github.com/apache/fluss/pull/2464#discussion_r2741163451
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java:
##########
@@ -492,6 +494,27 @@ private TableDescriptor applySystemDefaults(
newDescriptor = newDescriptor.withProperties(newProperties);
}
}
+
+ if (newDescriptor.hasPrimaryKey()) {
+ Map<String, String> newProperties = new
HashMap<>(newDescriptor.getProperties());
+ String formatVersion =
newProperties.get(ConfigOptions.TABLE_KV_FORMAT_VERSION.key());
+ if (formatVersion != null) {
+ throw new IllegalArgumentException(
+ "Manual configuration of '"
+ + ConfigOptions.TABLE_KV_FORMAT_VERSION.key()
+ + "' is not supported. The coordinator chooses
the appropriate "
+ + "KV format version automatically. Remove
this property from the "
+ + "table properties (current value: '"
Review Comment:
I agree on the future evolution point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
