leekeiabstraction commented on code in PR #220:
URL: https://github.com/apache/fluss-rust/pull/220#discussion_r2742543004
##########
crates/fluss/src/metadata/table.rs:
##########
@@ -373,7 +374,7 @@ impl TableDescriptorBuilder {
self
}
- pub fn partitioned_by(mut self, partition_keys: Vec<String>) -> Self {
+ pub fn partitioned_by(mut self, partition_keys: Arc<[String]>) -> Self {
Review Comment:
I went overboard with refactoring here. Well spotted. Will address in follow
up commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
